Fix feature flag refresh detection when page status is string#334
Closed
IvanTheBearable wants to merge 1 commit into
Closed
Fix feature flag refresh detection when page status is string#334IvanTheBearable wants to merge 1 commit into
IvanTheBearable wants to merge 1 commit into
Conversation
The underlying HTTP response status can sometimes be a string (e.g., "200") instead of a number (200). Explicitly cast the status to a number to ensure conditional refresh logic works correctly in all cases.
Member
|
Thanks for contribution @IvanTheBearable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature-flag refresh change detection currently assumes page response status is numeric. In some runtime paths, status is returned as a string, which prevents detecting a valid 200 response and can leave feature flags stale.
Addresses issue #333
What changed
Why
This makes change detection robust across status value types and prevents false no-change outcomes when status is "200".
Validation
Built test outputs
Ran refresh test suite for both ESM and CJS artifacts
All tests passed, including the new regression scenario